Skip to content

Decoding speedup #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
baltzell wants to merge 16 commits into from
Closed

Decoding speedup #1008

baltzell wants to merge 16 commits into from

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Dec 15, 2025 •
edited
Loading

  • Zero change to resulting output data
  • More caching, more hashing, less looping
  • Replace string comparisons with DetectorType comparisons
  • Replace string IndexedTable access with column indices
  • Remove safety checks on hash-based accessors
    and
  • Moveinstall-clara to bin
  • Add Clas12Reader CLARA service

See #949 for finer commits (had trouble rebasing across submodule changes).

Decoding for RG-D LD2 is now down to ~3 ms per event on ifarm23, my laptop, and GitLab CI jobs at JLab.

@baltzell baltzell changed the title Redecodering Decoding speedup Dec 15, 2025
@baltzell baltzell marked this pull request as ready for review December 15, 2025 22:02
@c-dilks c-dilks added the speed label Dec 15, 2025
@baltzell baltzell force-pushed the redecodering branch 3 times, most recently from 7ad2948 to 78a0d73 Compare December 18, 2025 00:55
@baltzell
Copy link
Collaborator Author

baltzell commented Dec 19, 2025 •
edited
Loading

hipo-diff reports success on clas_018779.evio.00001 for all the decoded banks below. But the filesize isn't identical, hmm (ifarm2402:/scratch/baltzell/*.hipo).

|                      BAND::adc |                                                |    644 (kb)
|                      BAND::tdc |                                                |    702 (kb)
|                       BMT::adc | ░░░░░░░░░░░░░░░░░░░░░░░░░░                     | 419687 (kb)
|                       BST::adc | ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░           | 576971 (kb)
|                       CND::adc | ░                                              |  20247 (kb)
|                       CND::tdc |                                                |  10015 (kb)
|                      CTOF::adc |                                                |   8559 (kb)
|                      CTOF::tdc |                                                |  10043 (kb)
|                     DC::jitter | ░░░░░░                                         | 101497 (kb)
|                        DC::tot | ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ | 723945 (kb)
|                      ECAL::adc | ░░░                                            |  61329 (kb)
|                      ECAL::tdc | ░░                                             |  39519 (kb)
|                       FMT::adc | ░░░░░░                                         |  98624 (kb)
|                      FTOF::adc | ░░░░                                           |  73456 (kb)
|                      FTOF::tdc | ░░░                                            |  54868 (kb)
|                       HEL::adc |                                                |   3865 (kb)
|                   HEL::decoder |                                                |    139 (kb)
|                      HEL::flip |                                                |      4 (kb)
|                    HEL::online |                                                |    745 (kb)
|                    HEL::scaler |                                                |      8 (kb)
|                      HTCC::adc |                                                |   2840 (kb)
|                      LTCC::adc |                                                |   3812 (kb)
|                      LTCC::tdc |                                                |   1093 (kb)
|                       RAW::adc |                                                |   2219 (kb)
|                     RAW::epics |                                                |      4 (kb)
|                    RAW::scaler |                                                |     86 (kb)
|                       RAW::tdc |                                                |   5179 (kb)
|                       RAW::vtp | ░░░░░░░░░░░░░░                                 | 222818 (kb)
|                        RF::adc |                                                |   2833 (kb)
|                        RF::tdc | ░                                              |  16663 (kb)
|                      RICH::tdc | ░░░                                            |  48323 (kb)
|                    RUN::config |                                                |   3436 (kb)
|                    RUN::scaler |                                                |      6 (kb)
|                   RUN::trigger |                                                |   2386 (kb)

@baltzell
Copy link
Collaborator Author

baltzell commented Dec 19, 2025

Ah, the expanded total event size (and count) from hipo-utils is identical.

@baltzell
Copy link
Collaborator Author

baltzell commented Dec 22, 2025

Oh, oops, RASTER::adc is missing. Checking for a CCDB duplicate ...

@baltzell baltzell closed this Dec 22, 2025
@baltzell baltzell mentioned this pull request Dec 22, 2025
Merged
@baltzell
Copy link
Collaborator Author

baltzell commented Dec 22, 2025

breaking this out into separate pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita is a code owner

@c-dilks c-dilks Awaiting requested review from c-dilks c-dilks is a code owner

@zieglerv zieglerv Awaiting requested review from zieglerv zieglerv is a code owner

@whit2333 whit2333 Awaiting requested review from whit2333 whit2333 is a code owner

Assignees

@raffaelladevita raffaelladevita

Labels

speed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baltzell @raffaelladevita @c-dilks